Piotr Findeisen
Piotr Findeisen
Add overloads for `checkArgument`, `checkState` and `verify` to avoid boxing of sole `double` format parameter.
The single invocation of `DomainTranslator.visitComparisonExpression` used to call type analysis 3 times: in `toNormalizedSimpleComparison`, in `isImplicitCoercion` and once directly in `visitComparisonExpression`. Extracted from https://github.com/trinodb/trino/pull/13567
It was temporarily disabled in March 2017 in commit a103a639e396608d6e75f68d0b039597cd352f35.
Supplements 78ca591580d8ef043dc539450170050b09ace32f (https://github.com/trinodb/trino/pull/13011) with test cases with a sign.
The Alluxio integration does not seem actively maintained and seems to have quite small user base (for example, searching for Alluxio over Trino Slack discussions since Jan 2022 didn't return...
Such a cast cannot reasonably be pruned away because the source varchar value can be any of multiple forms (surrounding whitespace, optional year sign, optional leading zeros for date components)....
https://github.com/trinodb/trino/runs/5554739990?check_suite_focus=true ``` 2022-03-15T20:15:12.8369005Z [ERROR] Tests run: 3124, Failures: 1, Errors: 0, Skipped: 92, Time elapsed: 2,386.423 s