Filiph Sandström

Results 13 comments of Filiph Sandström

> Most raw `__attribute__` have (should be?) replaced with the macros from AK/Platform.h. Doesn't look like there's one for NORETURN Fixed 🤠

> I don't like this - semantically these functions don't exist, not exist but don't return anything, so noreturn is the wrong tool. If your compiler is complaining about the...

> These updates seem all right and not super invasive or a burden for maintenance. Nice work! I left a few comments on future fixmes. Yeah, turns out that msys2/cygwin...

Should probably squash the fix commit and rebase instead of merging master to prevent merge commits. Other than that this looks great 👍

> @filiphsps please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @microsoft-github-policy-service agree [company="{your company}"] >...

https://docs.jsprismarine.org/ 🚀

This is still an issue. Will investigate after the big protocol rewrite. ![image](https://github.com/JSPrismarine/JSPrismarine/assets/108444335/73398004-1e70-48ed-b9ea-bd9de0817a8a)

IMO this solves the biggest hurdle with Ladybird/Lagom macOS-specific development. To call it a pain right now would be a big understatement. While you can get something ok setup with...

> It's -> its in commit desc The part of my brain responsible for grammar just shuts down when trying to write the body of a commit message. Fixed :^)

> What does this change? > > `FloatPoint::to_type` doesn't do anything special AFAICT, it's just a float-to-int conversion, same as we have now. You are correct that it's currently the...