Filip Bártek

Results 13 comments of Filip Bártek

This solution resolves the constraints in an arbitrary order, possibly updating the status of a HP more than once. My guess is that following a topological order of the HPs...

I have extended the changes so that generating neighbors and sampling random configurations works correctly with configuration spaces with conditions nested deeper than 1 level of `AbstractConjunction`. Both of these...

This pull request probably solves the issue solved by #219.

> [...] I don't immediately understand the large changes from @filipbartek to `c_util.correct_sampled_array` and `c_util.change_hp_value`, could you please give some further explanation on what you are doing here? Would it...

I am trying to minimize the changes introduced by this PR. 3 functions are affected: - `c_util.correct_sampled_array` - `c_util.change_hp_value` - `configuration_space.ConfigSpace.get_active_hyperparameters` I believe each of these is broken in a...

# Minimal example Try to run the following PCS with `test_sample_configuration_spaces.py`: [vampire.zip](https://github.com/automl/ConfigSpace/files/7170921/vampire.zip) If all the calls to `cs._check_configuration_rigorous` are removed from the test body, a `ValueError` is raised from `n.is_valid_configuration()`...

> So apparently there is an issue in the neighborhood generation that leads to the creation of invalid configurations. If you are familiar with cython and can have a look...

#197 modifies `change_hp_value` so that it produces a valid configuration in each of the calls invoked by the minimal example described above. Note that the proposed solution probably degrades performance...

Also note that the class `AStarNode` used exclusively in `AStarChaser` uses `food`, `nest` and `moving` hard-coded sprite names.

I think the test failures are caused by #221.