Filip Horvat
Filip Horvat
can you provide a more code examples ?
nice! I will review and merge tomorrow
I am using this package in my commercial project so it is important to me to keep this package clean. I see that you mixed 4 things in this PR...
I think your solution for 1. is not good enough, because when you need, for example, to filter by JSON your solution would now work.... with `public function whereRaw($sql, $bindings...
yeah, whereRaw is very specific, I would definitely go with this interface : `public function whereRaw($sql, $bindings = [], $boolean = 'and')` but I am not sure which solution is...
in your PR just use this interface > "public function whereRaw($sql, $bindings = [], $boolean = 'and')" and then this would work : ``` Order::setUseFullPathTableAlias(true)->joinRelations('item.seller') ->whereRawJoin("JSON_CONTAINS(items_sellers.payment_methods, '["Cash]')") ``` -------------------------- this...
"JSON sort" is currently not suported, but it is a good idea how to improve package
anyone with the PR with tests ?
done
same here