Foteini Giannaropoulou
Foteini Giannaropoulou
@cpapazoglou I'm not sure what your suggestion was :) Running `wp jetpack sync start`, aka performing a Full Sync, is indeed very expensive and we'd still miss any events triggered...
Linked PR is now ready for review. > While saving a float is good, it probably should also normalize the price in this function so any stored improper values are...
Thanks Kraft for the additional case and Jeremy for the PR! IMO given the method accepts a second argument for the currency, I wouldn't expect the `$price` argument to include...
@Automattic/jetpack-vulcan How do we usually handle the ESLint failing tests related to missing JSDoc elements? Should I manually fix those or add an ignore rule?
> Add eslint-disable rules related to JSDoc requires > @Automattic/jetpack-vulcan How do we usually handle the ESLint failing tests related to missing JSDoc elements? Should I manually fix those or...
> I've not looked through the full list of phan flagged issues, but certainly some look like false positives, eg `Error: UndefError PhanUndeclaredClassConstant Reference to constant MANAGE_PLUGINS from undeclared class...
@anomiex Many thanks for the phan advice, it was really helpful! > I'm going to be making a pass over these across the monorepo soon. When it's something in another...
Added a phan baseline via https://github.com/Automattic/jetpack/pull/37342/commits/30e2dd2d66d5c1ad5f843d6f94ca2455de721bda which includes all the remaining phan issues I plan to fix gradually in follow-up PRs while switching the usage to the package.
@darssen Many thanks for the review! Really appreciate the time you took! > left some comments, mainly regarding missing require_once and some inconsistencies in the @package annotation. I only pinpointed...
@anomiex Since you were also involved in this PR would you mind giving it a final check too? Many thanks!