Felix Wilhelm comments

Results 13 comments of


                                            Felix Wilhelm

Using regular expressions to match boolean operators.

Using variables in place of operators is not supported (and it would be pretty hard to implement as it requires significant changes to the used C and C++ grammars). I...

Native binaryninja support based on rust API

Thanks for the PR. This looks like a fun feature, I wasn't aware that binaryninja has a working rust API. A couple of stupid questions (related to this PR and...

Update vulnerable dependencies

Thanks for the PR @MatthewGentoo and sorry for not merging it earlier. I'll close this now as #67 already updated the vulnerable deps.

Create a script that runs common test cases against a codebase

Hi Alvin, good suggestion. I'm happy to take a pull request :)

Match the size of an array

Thanks for the feedback and the bug report :) At the moment, variables ($foo) don't match on number literals so this is expected behavior. I've been thinking about changing that,...

Handling of the >= operator is broken in specific cases

Nice catch. Thanks for the detailed bug report. This seems to be an issue in the tree-sitter CPP grammar. `b.x < 3 && c >= 5` is interpreted as an...

Crash when parsing query

Thanks for the bug report. I'm not entirely sure how you are able to create these crashes, at least I can't reproduce any of these using the CLI interface.Could you...

Add a small repl

Thanks for the PR. This looks pretty cool. The current argument ordering is based on grep/ripgrep defaults. Originally weggli also supported an empty path argument to search the current directory...

can not find problem

Thanks for the bug report. I'll take a look

Finding function declarations

Thanks for the bug report and sorry for the slow response. I didn't have much time to work on weggli in the last weeks. I think disabling the VALID_NODE_KINDS check...