Felix Schlegel

Results 10 comments of Felix Schlegel

> thanks a lot for the patch! sorry for the delay. No problem 😄 Thanks for merging!

@emasab I think this is ready to merge, thanks again for your collaboration here!

[For the record] The issue here is **not** that `swift-kafka-client` is setting the `modified` flag on the `librdkafka` configuration properties. The problem here is that in the following code snippet:...

IMO we should make the `KafkaConsumerMessages` `AsyncSequence` throw when we encounter `RD_KAFKA_RESP_ERR__PARTITION_EOF` since this is an option that is explicitly set by the user. Alternatively, we could emit this as...

> Can we ever recover from a partition EOF error? Like does this happen during rebalance or is this really a terminal state Not a terminal state afaik, just means...

Hey @mr-swifter, Thanks for this extensive list of items. It aligns very much with what we also imagine the future of this package to be! Here are some things that...

Here is a list of the options we are currently not supporting but might want to support in the future: (See [librdkafka/CONFIGURATION.md](https://github.com/confluentinc/librdkafka/blob/master/CONFIGURATION.md) for reference) **EDIT:** since #88 - [ ]...