Fela Maslen

> thanks for the PR. this looks like a good feature to include. I'm working on releasing v0.11 with animation speed updates. so might bundle this with that release. >...

This also applies to directives defined by external modules, i.e. which can't be detected through static code analysis. E.g. ```ts // rateLimit.ts import { rateLimitDirective } from 'graphql-rate-limit-directive'; const directive...

Sure, this can be implemented as a lint rule. But the lint rule would then have to know about grats-specific logic.

If we can agree on an approach here then I wouldn't mind contributing with an implementation.

@captbaritone thanks for sorting this out. It seems to work, except I now have the following issue: ``` Directive "@deprecated" may not be used on ENUM. ``` ~Looks like a...

Having done some more testing, this works really well 👍 There is a slight issue which is that the schema AST returned by `getSchema` does not contain the directive nodes...

FYI this is how I am currently applying the directives based on the extensions: ```ts type GratsExtensions = { grats?: { directives?: { name: string; args?: Record }[]; }; };...

Yeah I suspect there may be a use case for yielding an error and then carrying on yielding successful results. I wouldn't rule that out at least. The issue here...

I can't find much documentation for this, but judging from [this test](https://github.com/graphql/graphql-js/blob/8a95335f545024c09abfa0f07cc326f73a0e466f/src/execution/__tests__/subscribe-test.ts#L1043), it seems that calling `throw Error(...)` is expected to *end the subscription*. However, calling `yield new Error(...)` does...

I just did a very basic test using `graphql` (without yoga or any other libraries), and `yield new Error()` does not seem to send errors through to the response. As...