Felipe Alex Hofmann

Results 36 issues of Felipe Alex Hofmann

The following test is currently an integration test and needs to be changed to a proper unit test: https://github.com/sdv-dev/CTGAN/blob/89c6650dee814c448a45e95393e6ca1d12eb8e51/tests/unit/synthesizer/test_ctgan.py#L265-L296

internal

If we run the code below, we will see that sampled correctly keeps the relationship between the categorical values ~99% of the time: ```python data = pd.DataFrame({ '1': ['1.0', '2.0',...

bug

Currently, the fit function for the CTGAN synthesizer is a 140 line piece of dense code accomplishing a lot of important tasks. Modularizing it in to the same standard as...

internal

The `validate` method for `SingleTableMetadata` currently aggregates all error messages into one. This makes it so the traceback doesn't show where or why the error message occurred, so the only...

### Error Description There is a bug in the way sdv.timeseries handles time series of length 1. ### Steps to reproduce The code below reproduces the error: ```python3 import pandas...

bug
data:sequential
under discussion

Currently constraints store their columns as either `self._columns` or `self.columns`. Some constraints also set the `self.constraint_columns` attribute while others don't, which can cause confusion since it gets used in other...

internal

### Problem Description When using conditional sampling without passing any conditions an unreadable error is thrown. ### Expected behavior Either it should simply return any samples, or it should throw...

feature request
feature:sampling

We don't validate that the constraint is passed only existing columns, which may crash with mysterious error messages. Below is such an example: ```python3 import sdv from sdv.constraints import Unique,...

feature request

I believe the `OneHotEncoding` constraint doesn't work when data contains only one line, raising the error `No axis named 1 for object type Series`.

bug

The `get_likelihood` method below may not work as expected: https://github.com/sdv-dev/Copulas/blob/dfe3bb9cc035c8d4880724db69c86e749178e65b/copulas/multivariate/vine.py#L246-L258 An explanation of what this method does should be added, and we should investigate whether it works as expected.

bug