Francois Bleibel comments

Repositories
Issues
Comments

Results 4 comments of


                                            Francois Bleibel

Alias for a fixed size array allocated on the stack

Thanks, that looks like the right header. I'm looking for the N-dimensional generalization of this - something I can use to define 3D and > arrays.

Alias for a fixed size array allocated on the stack

Thanks, the CompactShapeHelper replacement was most of the code, and I can remove our own implementation of that. Subsidiary question: do you think matrix_shape and vector_shape from image.h should now...

`array` and `array_ref` `operator==` and `operator!=` don't short circuit

Removing it SGTM. I can handle the Google side upgrade easily enough.

Annotate types with ABSL attributes?

Good idea. Every couple of weeks, we see a new bug that looked like `view_type view = MakeArray()`. (to be fair, the same happens for std::string_views).