Fares A. Bakhit

icon indicating a website link https://faresbakhit.github.io/ icon indicating an email [email protected]

icon company Drop Me icon location Cairo, Egypt icon location Student at the Faculty of Computers and Artificial Intelligence - Cairo University

Results 6 comments of Fares A. Bakhit

Fix `AnyUrl.build` doesn't do percent encoding (#3061)

please review

Fix `AnyUrl.build` doesn't do percent encoding (#3061)

> Looks good in principle, can we get some benchmarks to see how much this slows down validation I'm not sure how this affects validation or how to benchmark pydantic's...

Fix `AnyUrl.build` doesn't do percent encoding (#3061)

Okay, I removed `pydantic.utils.percent_encode` in the latest commit. > The real question long terms is whether we should move this logic to rust, but provided the API doesn't change we...

Fix `AnyUrl.build` doesn't do percent encoding (#3061)

please review

Fix `AnyUrl.build` doesn't do percent encoding (#3061)

please review

Add `poetry.toml` to `Python.gitignore`

Fixed `merge conflicts` > I am curious if you explain the reason for the poetry toml over the lock file or if they related? #3911 No, `poetry.toml` and `poetry.lock` serve...