Yixiao Fang

Results 68 comments of Yixiao Fang

Hi, thanks for your PR. Could you please also modify the same part in Chinese version?

`mmdet .sh` scripts are missing?

LGTM. @tonysy please review the PR

Hi, thanks for your suggestion and PR. I think the description is not very precise. If we write `hook_cfg` in config files, mmcv will parse the config and we could...

> Sorry, I pushed commits by mistake to the original branch, and didn't know it will also appear here. The commits I added are trying to fix #400, I don't...

Hello, where did you add the code `cfg.custom_hooks = [dict(type="DenseCLHook")]`

Actually, as for this configuration, it is recommended to modify the [config file](https://github.com/open-mmlab/mmselfsup/blob/master/configs/selfsup/densecl/densecl_resnet50_8xb32-coslr-200e_in1k.py) The example: ```python _base_ = [ '../_base_/models/densecl.py', '../_base_/datasets/imagenet_mocov2.py', '../_base_/schedules/sgd_coslr-200e_in1k.py', '../_base_/default_runtime.py', ] # runtime settings custom_hooks = [dict(type='DenseCLHook')]...

> If I want to set that hook based on a flag that is provided to my main script, that won't work unfortunately. > > Also, it won't change the...

Thanks for your reporting. It's in our future plan

Hi, thanks for your valuable suggestion. Are you willing to create a PR to help us add it? Thanks in advance!