fakeshadow

Results 100 comments of fakeshadow

> could you explain why it's faster fortunes than 1-query test. Thank You. https://github.com/TechEmpower/FrameworkBenchmarks/blob/e49fddca6c27701586f4afaa98db4908abf0b976/frameworks/Rust/xitca-web/src/db.rs#L38 You can see the source code here. query statements is cached for fortune test and it's...

It's actually an interesting topic. The top scorers in single query are using batch mode and they have a significant perf drop in fortune test. I suspect it has to...

> The response in Xitca-web fortunes is cached ?? No. You can see the source code here. https://github.com/TechEmpower/FrameworkBenchmarks/blob/e49fddca6c27701586f4afaa98db4908abf0b976/frameworks/Rust/xitca-web/src/ser.rs#L55 Fortune take ownership of the data it owns. And in Rust when...

> Sorry I don't want start a war :) I know how work Rust. And that allways clean the memoryl > That's a legit question and I understand your concern....

I've never used it but according to this phrase "This producer has an internal polling thread and as such it doesn't need to be polled. It can be cheaply cloned...

> @fakeshadow Thanks for the quick replay > > but then I am getting tokio issue like actix-web internally using a different version then that snippet so it's not compiling...

A similar attack can achieved with garbage boundaries though I don't have example for it. The cause is the same so fix one would fix the other. The internal buffer...

No Condition not always produce middleware service. See: https://github.com/actix/actix-web/blob/5ca42df89ae4c4eda46fcb408ba5b13549f09ad7/actix-web/src/middleware/condition.rs#L55 Condition only call new_transform and produce middleware service when you pass true to it. You always provide the factory type for...

`MyMiddleware` is just a constructor for the real middleware. Why you make it not have an easy constructor based on condition? If not how were you using `Condition`?

It's wrong to blindless return internal error when paylaod is half consumed. Instead it should alter the connection state to close if necessary.