Faisal Alvi

Results 52 comments of Faisal Alvi

The PHP Unit tests are failing with PHPUnit `9.5.21` version. Hence I have changed the min required PHP in the composer file to `7.1`, which keeps PHPUnit `7.5.20` and the...

As mentioned in https://github.com/10up/simple-local-avatars/pull/143#discussion_r942310144, the PHPUnit failure is due to the fix required in the upstream, and the PR is already raised https://github.com/10up/wp_mock/pull/164, so we can ignore the PHPUnit failures...

@ajmaurya99 thanks for the report. I have tested it as per your instructions and the crop issue is occurring in the customizer too. ![SLA-100](https://user-images.githubusercontent.com/25176325/157882498-264ec5c9-20bf-46f8-be44-5ee334bbb470.gif) [image link](https://www.screencast.com/t/flEYfTayuJl)

@jeffpaul can you please follow up on the core ticket so this gets resolved sooner?

@jeffpaul Site Logo block does not offer a crop feature **inside the media library popup**. It simply allows to choose an image, and the crop is performed like this: ![sla-100-2](https://user-images.githubusercontent.com/25176325/170018550-8d9e7335-ecf4-4068-9048-1616e907df96.gif)

@jeffpaul Yes, we should provide (initially) 2 options: square and freeform. @cadic has already provided a suggestion on it in https://github.com/10up/simple-local-avatars/pull/130#issuecomment-1133242447, I will look into it. However, we need a...

Update: Internal discussion with @ajmaurya99: https://10up.slack.com/archives/CG6QB7HEU/p1657221871321319

@zamanq do you think we should completely remove the crop feature (inherited from customizer) as this is preventing non-admins to crop images And replace it with another crop tool? (_note:...

@jeffpaul Should we publish a new release (2.6.0) this month and tackle this "new crop tool" enhancement in a separate ticket and plan it for the next release (2.7.0)? (Optional)...