Fabio Martino
Fabio Martino
Hi looks good! Just missed the switch for german language into: ../src/app/shared/components/header/header.component.html around line 72 {{ 'German' | translate }} and into ../src/app/app.component.ts line 10 and 13 translate.addLangs(['en', 'fr', 'ur',...
I don't have write access to this git repo. I only can tell that your changes looks good for that desired functionality.
Fix with this PR (aka Angular 7) https://github.com/start-angular/SB-Admin-BS4-Angular-6/pull/261
Agree! 👍
Yes would be a nice feature as UI choice. What you can do to help will be... migrate a generated new project ... If you have a previus experience with...
Have you try this? ``` // app.initializer.ts import { AuthenticationService } from '@app/_services'; export function appInitializer(authenticationService: AuthenticationService) { // return () => new Promise(resolve => { // new Promise((resolve: any)...
> I noticed you closed this PR. Do you not want it merged? I opened this PR as a Work in Progress (WIP) or a draft because the proposed feature...
> Thanks for doing this work. Please feel under no obligation to implement this review, I can take it from here if necessary. > > I just have one concern....
I re-open as a Draft.
To verify whether the older versions of Capacitor (prior to version 6) require these changes, we need to test on those specific versions. This is because the new SPM already...