Aaron F

Results 36 comments of Aaron F

Are there any feedback on this? Is there something I can do to bring this forward?

> How close are these webhooks to GH's? If we can keep compatible, that's better. I am not sure if I got you right. The webhooks have no connection to...

Is there anything I can do to process this further? Any open questions @lunny ?

I've checked the GitHub webhooks for wiki changes. The following event got triggered when the "[x] Wiki" Checkbox is checked on the Webhook events: ``` "pages": [ { "page_name": "RENAMED-TITLE",...

> Could we use `Doer` instead of `Sender`? Keep compatible with Github will make some tools changes easier. For the Payload Struct, it is always ```Sender``` (see [here](https://github.com/go-gitea/gitea/blob/ed4774588086f4f493f717e5bb3f4950e1f525c3/modules/structs/hook.go)), for all...

Another week passed away. Are there anything I can do to move this forward @lunny @lafriks ?

I've made a PR for this to support webhooks for the internal wiki a month ago. Still waiting for a proper review.

@dvikan Can you elaborate a little on that "keep vcs history" statement? The history is always there, only a ```git blame``` will look a little weird. But that's ok IMHO,...

I disagree with that statement, but I am fine with your suggestion (conform new/changed code to modern style).

I agree that the sourcecode needs a structural overhaul, but I am not sure if this can be done in multiple stages. It brings in too much complexity to merge...