Eytan Avisror

Results 57 comments of Eytan Avisror

@preflightsiren are you referring to usage with native upgrade strategy? i.e. not using upgrade-manager/crd strategy? Can you share more on the use-case, are you upgrading instancegroups while jobs are running...

We should first do #173

@backjo interesting, so you keep multiple IG on min 0, and in case you need to scale up beyond max of ASG-1 - ASG-2..N. would scale up additional nodes for...

We should also add a status field with `errorReason` that gives a clear message or code on what was the reason for moving to error state

Yeah, we use a similar mechanism with https://github.com/keikoproj/lifecycle-manager But I'm not sure about adding an SQS queue, EventBridge, etc - it might eventually end up being more API calls than...

There might be a problem the with setting of `lifecycle=spot` in this case. I think the current logic depends on whether a spot price is set or not, and not...

Technically the subnet selection in the CR corresponds with AZs, so are you suggesting to resolve the AZs for those subnets and maintain an annotation such as `instancemgr.keikoproj.io/availability-zones: usw2-az1,usw2-az2,usw2-az3` ?...

we should use validating webhooks to block instancegroups without common required fields. validation should be soft (only check if CR has values, no need to go and check if those...

Maybe a cleaner API would be ```yaml conditionals: | - annotationSelector: 'instancemgr.keikoproj.io/arch = arm64,instancemgr.keikoproj.io/os-family = amazonlinux2' > required: true defaults: spec: eks: configuration: image: {{ .ArmImage }} ``` But if...

@kevdowney I think this is more of a client problem. What you want is a condition where if `{{ .ArmImage }}` is missing / blank, there is no fallback on...