eyalkoren

Results 150 comments of eyalkoren

I completely agree it's time we address that! We will probably have to do some research and apply the proper implementation per DB type/vendor. One thing to keep in mind...

@kuisathaverat can you have a look? Specifically - https://github.com/elastic/apm-agent-java/blame/master/Jenkinsfile#L126-L185, https://github.com/elastic/apm-agent-java/blob/master/scripts/jenkins/smoketests-01.sh#L9 and https://github.com/elastic/apm-agent-java/blob/master/scripts/jenkins/smoketests-02.sh#L9

It is not a low number as all the repeated ones are out of the smoke tests, meaning- instead of running 189 of those, we run 298. And more importantly-...

> Related to an earlier point, the first time I tried to run the smoke tests sequentially, the entire test suite timed out after an hour which leads me to...

@cachedout thanks for the investigation, this is very useful! The good news are that we can considerably reduce the build time with the same number of Jenkins nodes/jobs. I think...

> we have to categorize the tests to can run them in parallel by category. OK, let's do that. Let us know what we should do.

Since the optimal solution would be through the implementation of https://github.com/elastic/elasticsearch/issues/63530, and we will eventually want to rely on it, maybe trying to get information on when this is expected...

Our tracing specs, both for [spans](https://github.com/elastic/apm/blob/master/specs/agents/tracing-spans.md#outcome-api) and [transactions](https://github.com/elastic/apm/blob/master/specs/agents/tracing-transactions.md#outcome-api), already encourage (but not mandate) agents to expose such an API. The Java agent, for example, offers the [`setOutcome`](https://www.elastic.co/guide/en/apm/agent/java/current/public-api.html#api-transaction-set-outcome), which I believe...

OK, I read it as if a public API for setting the outcome is a valid alternative that you may not be aware of.