Eneko Uruñuela
Eneko Uruñuela
Is this issue still a thing?
> I forgot, did we pause this merge for some reason? I feel like I recall some hesitation due to not being sure about precisely what caused the underlying issue....
> @handwerkerd what difference, if any, is there between orthogonalizing the rejected components w.r.t. the accepted ones and including both rejected and accepted components in the initial regression (i.e., nonaggressive...
> I hesitated to tag Cesar because I remember him very patiently explaining it to me in DC and I've completely forgotten it all! 😆 I believe he wanted to...
@tsalo could you please tell us where this is done in the code?
Given that we're planning on merging `auto` into [phy2bids](https://github.com/physiopy/phys2bids) soon, I'd say we wait and see how it goes. Some of us will have had some experience with the tool...
Cool. @smoia, @rmarkello and I will get back to you then with our experience with `auto` once we merge it in `phys2bids`.
@smoia finally made it work on phys2bids! 🎉 🍾 We can continue with this discussion (if necessary) once we see it work in phys2bids for a few weeks.
I can take care of these additions to the reports. I know the code quite well.
> Second, the author proposes including checks for "I ran this code locally" and "I wrote the necessary tests" in the PR template. These would be easy enough to add...