Aaron Gibson

Results 13 comments of Aaron Gibson

I think a deeper issue here, to be honest, is the fact that `def get_content()` is not (or cannot, to the best of my knowledge,) be a coroutine. It is...

> True, although I'll point out that as the docs say, this is not intended to be a high-performance file server. Maybe not for localized static files, but this may...

I have tentative code that works for this, but it assumes that a few hacks used when interacting with Tornado actually work: ``` """ proxy_protocol.py Implements the HAProxy Proxy Protocol...

One way this PR _could_ be improved is if `tornado` offered an API of sorts that permitted partial searching as data comes in. For example, something like this (some details...

Is it still possible to create the streaming `multipart/form-data` as a part of tornado itself? Or has tornado deferred to the posted third-party library above? Lookyan's library works great and...

I actually had my own implementation here: https://github.com/eulersIDcrisis/torncoder/blob/main/torncoder/file_util/_parser.py This implementation here is my own, and I wrote a "thorough" test case that sliced some input in every way (to test...

Sorry, I guess my repo there is private; I use it with various things when dealing with tornado. I guess I could make it public. Anyway, I've started a PR...

A seemingly simple fix is to wrap calls [here](https://github.com/tornadoweb/tornado/blob/924bd4c91ead50cf1850c2b45b7e7bd5c5cf6320/tornado/simple_httpclient.py#L690) with code like: ``` class _HTTPConnection(httputil.HTTPMessageDelegate): # ... def data_received(self, chunk: bytes) -> Optional[Awaitable[None]]: if self._should_follow_redirect(): # We're going to follow...

If it is any help, I created a PR here: https://github.com/tornadoweb/tornado/pull/3471 It is currently in draft, but (after checking the linter state and so forth), I can mark it ready...

@bdarnell , if it is any consolation, I've run `tox` which passes for me (including the docs and linter checks).