Ethan Donowitz
Ethan Donowitz
With our work to split syncstorage-rs into separate crates, we have removed `#[cfg(test)]` from those database methods that are only included in tests. (Code specific to the `test` feature is...
Currently, the set of functions operating on batches are implemented for both the Spanner and MySQL backends. We include a number of `_batch` methods on the `Db` trait. It might...
## Description I revamped the naming in this PR to make things clearer. At first, I considered simply adding a "syncstorage-settings" crate with a "tokenserver-settings" crate as a dependency, but...
With the completion of #1277, the database backend (either MySQL or Spanner) will be fixed at compile time instead of runtime, so we will no longer need to support runtime...
Now that Actix 4 has been released, we should upgrade syncstorage-rs to the latest version. [Here](https://docs.google.com/document/d/18_ZxdDhUzjUUn9vHUVg5E8pF46vq7s_-Y-8V5thsYqA/edit#) is a list of the changes that are required for the upgrade. As part...
Much of our code currently lacks doc comments describing the interface. To resolve this, we should enable the `missing_docs_in_private_items` clippy lint and add any doc comments that may be missing....
We've ignored a number of the warnings emitted by `cargo audit` due to an inability to upgrade the necessary dependencies. After the upgrade to Actix 4, we'll have updated many...
We call `to_owned()` in many places throughout the code. We could move these calls to more centralized locations by having functions and methods take `Into` instead of `String` directly. Then,...
Constructing a `TokenserverError` is arduous in situations where an error needs to be tailored to a very specific situation. In particular, where callers can't make use of the utility methods...
We should do a final audit of the Tokenserver code to ensure that every situation has integration test coverage, adding tests for any missing coverage. We should also do a...