Ethan Donowitz
Ethan Donowitz
This can't be merged until #1276 is merged
I appear to have run into the same or a similar error 🤔 ## Check list - [X] I have read through the [README](https://github.com/wfxr/minimap.vim/blob/master/README.md) (especially F.A.Q section) - [X] I...
> Is it possible to add a parameter to the config to give a public url like the old syncserver had? This would probably be the path we'd take to...
@pjenvey I like your idea about removing the `Trait` suffix and adding an `Impl` suffix to the types that implement the traits. I'll make the change!
CI was stuck so I did a `git commit --amend --no-edit` and force pushed, though I still see that GitHub appears to be waiting for the status of the `e2e-tests`...
@jrconlin The original `e2e-tests` job was removed and replaced with `mysql-e2e-tests` and `spanner-e2e-tests` -- should I update the branch protection to reflect that?
@jrconlin Ok I updated the branch protection settings, and that seems to have fixed the issue. I think this needs another approval before I can merge