Ethan Peterson

Results 12 comments of Ethan Peterson

Alright, I am going to go sheet by sheet through this starting with TOP.SchDoc. # Top.SchDoc - Clean up the grid lines in altium. Set your snap grid to 100...

# STM32.SchDoc - It is nice that much of this can carry over from prior work. I am going to focus on the parts you have added as the oscillator...

# IMU.SchDoc - Would consider pasting in the application circuit from the datasheet on the schematic page for reference ![image](https://github.com/qfsae/pcb/assets/16881963/7547a6e5-ffa7-4d8f-af2d-d2ae35494fc4) - This can be cleaned up - Make one 3V3...

# CAN.SchDoc - Nothing to say here. Termination switch mistake is addressed. Looks good to me. - Maybe add a note for layout to indicate which switch position enables bus...

# Connectors.SchDoc - Seems reasonable overall. Not sure if a dedicated page is really needed. - You should consider adding some capacitors on the 12 V connectors. Bulk caps are...

# 5VBulkhead.SchDoc - Add designators. Lookup altium auto annotate. I would just reset all the designators and let altium auto label. Will prevent weirdness like this. ![image](https://github.com/qfsae/pcb/assets/16881963/ba5f32e3-b8a6-4dd0-b006-a4230c164805) - Also the...

# shiftRegister.SchDoc - Dead short between 5V and ground. MUST FIX, will cause the MAGIC SMOKE ![image](https://github.com/qfsae/pcb/assets/16881963/afc879d3-ed9a-443a-b4f4-03e7669dc9a6) - Also include a bypass capacitor 0.1uF at the power input. of the...

# Debugger.SchDoc - Cut and paste from the ol PCB design. No major things i see. - This deisgn did not use the celestial lib so you will have headaches...

# DebuggerConnectors.SchDoc - add a ground return to the UART header - ![image](https://github.com/qfsae/pcb/assets/16881963/b78d13a4-d4e5-470e-82df-6d5fb572d07d)

# 12V_LS.SchDoc - instead of pulling up the PG pin of the switch in this schematic directly, make the PG pin a port. Tie it all together in the bulkhead...