John Eslick

Results 55 comments of John Eslick

First time point in dynamic models

@blnicho or @jsiirola I'm going to fix this, but want to make sure I understand the requirements. I think the answer here is to move this optional constraint for the...

First time point in dynamic models

I fixed the PID controller. I couldn't find other instances in the IDAES-PSE repo. I think we can close this?

First time point in dynamic models

@blnicho, thanks. We can definitely break the initial condition calculation step out of the PETSc utility and use it as a more general method if it makes sense. At least...

Models needed for sofc example

I'll approve, but you'll have to run black on this thing to get the tests passing.

Requests for new tutorials/examples

Related to issue IDAES/idaes-dev#340, deciding how to organize these new examples.

[RFC] Have initialize methods return final solver status

As a less disruptive alternative, we could add and initialized flag to the models. Maybe in the ProcessBlockData class. Give it an enumerated type like NOT_SUPPORTED, NOT_RUN, SUCCESS, FAIL. Not...

[RFC] Have initialize methods return final solver status

@andrewlee94, this is a really unpleasant suggestion, but I've wondering about using @Robbybp's context manager that allows you to temporarily fix certain variables or get submodels for initialization. I know...

Demonstrate PyROS on rankine cycle IES example

I didn't read through everything, so I may have missed this, but have you considered scaling?

Demonstrate PyROS on rankine cycle IES example

I'm super late, but IDAES scaling is slightly complicated. The way it works (very roughly) is that you specify scaling on a subset of variables. Usually like pressure, flow, sizes......

add utility tool to deactivate/activate scaling suffixes in the models

@andrewlee94 I talked to Miguel about this, and I think Pyomo does catch this on purpose and throws and exception figuring you are making an error trying to give Barron...