Erin Doyle comments

Results 8 comments of


                                            Erin Doyle

Switch from moment to date-fns?

`Luxon` does look more viable to me than `date-fns` at this time. > Localizations and time zones are implemented by the native Intl API (or a polyfill of it), instead...

Provided an easier means of extending test for redundant alt text

So are you suggesting adding an options prop that could take additional words to prevent in the alt text or to allow?

"The `alt` prop cannot be empty string if role="presentation" is not set" when it is

Yes this does look like a bug. It looks like the "The img does not have an `alt` prop..." rule is not checking for `role="presentation"`. We can look into this.

Repeated warnings

There is a bit of a "feature" that could be considered here. The amount of noise and pain it causes when you don't meet a11y standards really motivates you to...

When I report with severity error, I get JSON serialization errors for the DOM node

@kldavis4 I don't have enough info from this stacktrace to have any ideas as to what the problem is. I'm not sure if perhaps there is some series of promises...

Using a11y with preact and preact-cli

I certainly have not tried using this library in a preact project before and I'm not sure if others have been able to successfully. So yes it's possible it's not...

Using a11y with preact and preact-cli

I did some work on looking in to this and no react-a11y is not compatible with Preact out of the box. I did not test it but I'm guessing it...

Label checks should not apply to elements with role of "separator"

It looks like we could use a whole new rule module for validating `role="separator"` based on the links you posted. It looks like we need to identify when the element...