erik-nilcoast
erik-nilcoast
I just stumbled on this. I think I'll use your branch :)
This would have just saved me some issues in production :). It'd be great if `gin` supported this.
> Hey I just happened to create #1442 so given you seem to have recently looked at the yt-dlp code, would you know if it's possible to, by adding yt-dlp...
Correct, grabbing subtitles from youtube is only possible on the client without trying to bypass their controls. This is doable, and I've done it using this code in a browser...
> I even coded [something](https://github.com/thiswillbeyourgithub/wdoc/blob/82b7f8150dab63b6cc13fc133df6622ab0021f23/wdoc/utils/loaders.py#L2559) in the passed to turn vtt format into something human readable yet without losing timestamps by just keeping the timestamp in HH:MM:SS format every 15...
@thiswillbeyourgithub sorry, no clue. I'm not sure I can provide all of that context. I just occasionally fix things in this codebase. Videos weren't downloading correctly, with this change, now...
@yusukebe I completely agree :). I just wasn't sure if you were up for any changes. I can work on a "real" fix.
I see this as well. I'm going to see if I can fix this locally. I also just added an option to specify the mermaid version.
Here's a PR for setting the mermaid version: https://github.com/yusukebe/gh-markdown-preview/pull/63 and removes the copy paste buttons which were interfering with mermaid.