Eric Stengard

+1. Ideally -c should print the diff to stdout. An alternative could be a flag which toggles diff view or the condensed view that -c defaults to now.

@fsouza is there a requirement to keep backwards compatibility? Otherwise I'd propose that --check spits out the diff as well. If we need backwards compatibility maybe another keyword should be...

> @ericstengard can we do that via a new flag? This way we can keep backwards compatibility. Yes I'd say that it's fine. I'm thinking something like --check-verbose or --check-diff...

This should've been fixed already but #148 fixed this again. @fsouza can we close this?

Would it be enough to change https://github.com/open-telemetry/opentelemetry-python/blob/d01dbc219ce5a853cf72a8854d45701724e334b6/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py#L98 to ``` aggr_key = frozenset(attributes) ``` Edit: Nope that doesn't seem like the way forward.

> I think the fix here would be to convert the attribute value to an n-tuple if it is a sequence before calling `frozenset()`. Would you be interested in sending...

> > * Is it set in stone that https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-api/src/opentelemetry/util/types.py#L18 should supports lists, hence this being a bug? One possible way to go would be to let the caller do...

Sorry for the lack of response here. Looking at https://github.com/open-telemetry/opentelemetry-python/blob/d01dbc219ce5a853cf72a8854d45701724e334b6/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py#L84 it would seem that the better long term solution is to do away with frozenset. In the meanwhile I'd venture...

I'm also interested in this being resolved. Would it be appropriate to bump the comment at https://github.com/mosquito/aio-pika/pull/533#issuecomment-1575363432 since it seems that we're close to a resolution but have yet to...