ericscheid

Results 354 comments of ericscheid

Does this work even if the `` is hidden? This sometimes happens when the caption is provided for accessibility support but is otherwise not visible

https://github.com/naturalcrit/homebrewery/blob/c1d8c8f3411648fa091e1ca87223306bf0c6ce2e/client/homebrew/brewRenderer/brewRenderer.jsx#L115-L117

There has been [additional interest](https://www.reddit.com/r/homebrewery/comments/sq2o3h/is_there_a_non_patreon_way_to_support/) in one-off donations (which doesn't involve an unintuitive sub/unsub process) We could set up a ko-fi account, or set up [GitHub Sponsor](https://github.com/sponsors/ericscheid/waitlist) (there might be...

https://github.com/naturalcrit/homebrewery/blob/master/client/template.js has been updated to include the brew title into the `` element. The brew is passed in via `props`, so nothing elsewhere needs updating. There are some other html...

The top of the template could look more like this: ``` ${title.length ? `${title} - The Homebrewery`: 'The Homebrewery - NaturalCrit'} ``` So .. `add a lang="en"`, add a `charset`...

The `lang="en"` for the share page should remain as `en` because the share page has english language UI elements. Later, once the brew meta data includes an author specified `lang`...

Better to attach an event listener to a higher container, and from there detect if the element clicked was the brewItem (and not the individual links in the sidebar. ````...

So, something like this, but optimised/linted/etc ``` document.querySelector('.phb') .addEventListener( 'click', (event) => { // do the hard work here let brewItem = event.target.closest('.brewItem'); if ( !brewItem ) return true; if...

Hold off unless there is an obvious and simple incremental PR. There is work in progress on brew.tags, of which brew.systems is arguably a subset of. That's a much bigger...

> is it worth the potential inaccuracies as far as "Brew search" is concerned [because user generated content likely inconsistent] Not worth letting that happen. Implementing a `` is pretty...