ericrdunham

Results 5 comments of ericrdunham

@avaris yes, absolutely, but this would allow for a use case where the warnings wouldn't even be emitted, such that `--fatal=warnings` could be enabled in a CI pipeline without having...

@avaris I didn't update the original branch name, but I refactored this now to not add an additional feature and was curious if this was more of what you had...

> "Yes" on the idea, "not sure" on the implementation :). I was thinking somewhere along the lines of implementing [`callHandlers`](https://github.com/python/cpython/blob/c6e7cf1ee09c88d35e6703c33a61eca7b9db54f3/Lib/logging/__init__.py#L1641) in `FatalLogger` (instead of `warn` or `error`) and raise...

Given this latest response, I feel like I might be missing the meaning of 'fatal' in the context of Pelican. I was trying to follow: ``` parser.add_argument('--fatal', metavar='errors|warnings', choices=('errors', 'warnings'),...

Ahh, I see. I was approaching it from the other side (getting `LOG_FILTER` to work with `--fatal`). :) If I get a non-zero from `pelican`, I'd be inclined to re-run...