Eric Proulx

Results 38 comments of Eric Proulx

I’m really not an expert on AST but since the actual cop is capable of finding the explicit `table_name` definition, I thought it could be possible to find the `table_name_prefix`...

> Change the code to be `v1 + v2 == 5`, does it pass? If not it's a bug ;) It just doesn't work since arity is set to 1...

> This is some advanced ruby-fu, so ... I don't know? :) IMO, I would just override the `inspect`. It's faster than passing by `method_missing` which is notoriously known to...

> @ericproulx by sanitize you mean filter out or replace? Replace

> What's the downside? Follow the file structure convention if we can label that has a "downside".

> I'd like to merge this. > > 1. Update the language around auto/lazy loading/reloading in README. > > 2. What externally visible contracts are we breaking? Should we be...

@dblock I've found something else related to gem `grape-swagger`. Versions below 2.0 are ` grape ~> 1.3` and `ruby >= 2.7`. Above 2.0, its `ruby >= 3.0` and `'grape', '>=...

> @ericproulx Want to add some words to those files and let's merge? Done. I mentionned something about Monkey Patch that might result in a Zeitwerk Error.

With the latest version of `rspec-rails`, `4.0.0`, we have the issue ``` /.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `call'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:30:in `render'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `call'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:30:in `render'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `call'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:46:in `render_with_wicked_pdf'", "/Users/eproulx/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/gems/wicked_pdf-1.4.0/lib/wicked_pdf/pdf_helper.rb:30:in `render'",...

@russointroitoa any updates on that PR ?