Eric Mustin

Sorry for the delay here in reviewing. Generally I think this is a good approach and we appreciate the contribution, and if i'm understanding the implementation correctly, we're successfully avoiding...

@zachmccormick Hey there, thanks for flagging this. We have some upcoming sprint work scheduled around improving our Rails Instrumentation and I think it would make sense to try to include...

just ➕ this issue and pr @Everettss any thoughts on the associated PR here? fwiw this helps unblock uses cases which want to use the `saveResponse` option on larger response...

assigned myself to this so i can remember to review while ariel is out, apols on the delay here chris.

hey @chrisholmes just ack'ing your followups, plan to catch up here otw. hectic week for me there's been some internal stuff going on at work. one thing we discussed in...

@chrisholmes i'd be ok with that. Did not catch up otw, as these things go. will review this evening.

In the example above, it seems like perhaps there's some `pg` or `mysql` instrumentation the level _under_ activerecord, which if that's too noisy, can be disabled by simply disabling those...

@blumamir that sounds novel and reasonable to me. I think that's a permissible use of context according to a quick reading of the specification. I'd been keen to hear if...

@blumamir I would imagine a custom sampler could handle this (though i'm not 100% sure, i think you'd need to maintain the state that a context key otherwise would somewhere),...

The min compatible version for this instrumentation is, in fact, 1.1.0 https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/37696bd2c5c8c58c072937e69834b562bf2c42a5/instrumentation/pg/lib/opentelemetry/instrumentation/pg/instrumentation.rb#L12 What the reason for that min version is, i'm not totally sure. @ahayworth contributed this instrumentation, perhaps he...