Erich Keane

Results 57 comments of Erich Keane

As another compiler engineer, I can perhaps clarify: I think the confusion here is the difference between 'function' and 'function declaration' (and lesser-so, function definition). I believe the diagnostic is...

Ah, I see! I was missing the context of that macro. I can understand your reluctance to make the change, though this is likely going to have to be a...

> > > @j-stephan, thanks for checking that. I tried it myself and I see the same issue. > > Based on the discussion, the original example doesn't seem to...

Min Repro that shows the problem: ````bash-4.2$ cat temp.cpp template __attribute__((sycl_kernel)) void kernel(const Func &f) { f(); } template struct parent { template struct child { }; //using Mask =...

@schittir : This is likely a good task for you. See the SYCLKernelNameTypeVisitor, which isn't catching this situation for some reason. The minimal example I provided should be enough to...

> > > @j-sthephan. My bad, it works with the `dpcpp` compiler packaged with the OneAPI SDK but not with the clang++ compiler. > > ``` > tapplencourt@foo:~/tmp> cat bool.cpp...

> > > Bingo. The code compiles with it: > > ``` > tapplencourt@arcticus12:~/tmp> clang++ -fsycl -fsycl-unnamed-lambda bool.cpp > tapplencourt@arcticus12:~/tmp> > ``` > > As said before, maybe it should...

I don't believe this is related at all, the fact pattern is a lambda with a requires clause defined inside a concept, which causes the template arguments to not be...

As an update, I've come up with a patch that is not quite ready for review (I have a ton of TODOs) that proves out my idea of splitting ConceptSpecializationExpr...

Put up a review here to have the code-owner take a look: https://reviews.llvm.org/D136451 but others are welcome to it as well.