eric-hughes-tiledb
eric-hughes-tiledb
I come to this topic acting as the implementer of a library that others will use. It's not my decision to make about whether termination is appropriate or not. In...
> header files in logger.h Include `common-std.h` in that file, then use the names that have been incorporated into the global namespace without qualification.
> There remain major problems with this PR. There's more. That's all I have time for this morning.
The missing symbols `Catch::StringMaker`, etc. are entirely in the Catch2 library. We use it in header-only mode, which does not have this issue. My best guess, with limited information, is...
This should be rebased after #4405 merges to see if it alleviates anything.
It looks as though this strict preprocessor option is not compatible with VS 2019; there's warning inside the compiler's include files that's being escalated to an error. I doubt it's...
>a fix for [SC-26982](https://app.shortcut.com/tiledb-inc/story/26982/remove-polling-for-bucket-object-propagation-deletion-from-the-gcs-vfs) That issue does not report a defect. What's there to fix? A putative performance improvement is not a defect. The GCS docs are incomplete and ambiguous...
So as not to confuse the practical advice Luc gave, you'll want to compile TileDB at present with `-Wno-float-equal` overriding whatever you might have set by default. The larger issue...
> making it a friend causes the need to be in `tiledb::sm` Friend declarations can be for namespace-qualified identifiers. `friend ::something` for the global namespace, for instance.
Still reviewing...