Eric Forte

Results 19 comments of Eric Forte

> **Am running the test here** > > with GITHUB_TOKEN --> https://github.com/elastic/detection-rules/actions/runs/15141279107 with WRITE_KIBANA_DETECTION_RULES_TOKEN --> https://github.com/elastic/detection-rules/actions/runs/15141096361 > > Both the token seems to not have access to comment on issues...

> > I think this has to do with the change in this PR to the `uses: peter-evans/create-or-update-comment@v4` as writing/creating issues vs comments is the same authentication level (both of...

Just adding for context for reviewers on the ^ PR. This issue can be more easily tested via DaC commands (loading just a specific rule to the rule loader), but...

Closing as this issue has been resolved via https://github.com/elastic/detection-rules/pull/4956 ![Image](https://github.com/user-attachments/assets/e0dc048c-2ba4-478b-92e4-b490bd21693a)

We might be able to leverage Kibana's Lexer/parser (ref: https://github.com/elastic/kibana/pull/213006/files) 🤔

@OzzyKampha Can you try running the following to reduce some of the errors? `detection_rules kibana --ignore-ssl-errors true export-rules --strip-version -d test-export` One of the errors for instance is `Rule Malicious...

@0xBAADF0OD what command are you running that is resulting in that error? And on what file contents? If from Kibana, could you provide the ndjson? Thanks!

@OzzyKampha providing `--strip-version` strips the version fields from all rules when exporting them from Kibana. This version would get set based on what Kibana thinks is the version of the...

Hi @pberba 👋 Thanks for creating the issue! Do you have an example export Kibana rule with an action without an actions connector from Kibana that can trigger this? Ideally...

👋 Hi @pberba, unfortunately the collision on name is by design. The generic loader needs to support the following types: `TOMLAction | TOMLActionConnector | TOMLException` These types are not all...