erankor

Results 317 comments of erankor

That is inaccurate, nginx-vod-module does not use the access phase, and even if it did, there is no problem to register multiple access phase handlers. The problem here is that...

I just encountered the same issue, using `set_timeout` solved it... I'm guessing the issue is in lua-nginx-module and not here, can anyone have a look at this?

Looks like librdkafka was not identified during configure, most references to librdkafka are wrapped with `#if (NGX_HAVE_LIBRDKAFKA)` while this one is not. While it is possible (and probably makes sense)...

I see you are compiling it dynamically, the config file wasn't fully ready for that... please try this pull - https://github.com/kaltura/nginx-kafka-log-module/pull/6

@NaturalL, I didn't understand what error you are getting

That is correct, librdkafka handles reconnections, there are params to control it (reconnect.backoff.ms / reconnect.backoff.max.ms). The TODO you mentioned got here by inheritance from the module on which this one...

You can do it by using a variable for `topic` and having it evaluate to an empty string when you don't want to send the message. If `topic` is empty,...

Thanks @larry-cdn77, I'm ok with adding a generic directive for arbitrary librdkafka params, but prefer not to remove the existing ones, since - 1. I think the defaults in the...

Right, better use the post attribute for this, instead of mapping it in the code. Also, for setting the defaults in ngx_kafka_log_init_kafka, I think it would be more elegant to...

One thing I forgot to mention - the styles are on the "Spanish" subtitles, need to choose that one...