Eugene Rudoy
Eugene Rudoy
@Predelnik I'm also affected by the problem (or a very similar problem) since a couple of months. But only recently found a way to reliably reproduce it. Notepad++ 8.4.3 (64-bit...
Hmm, what about ignoring (i.e. not checking) the words containing `0` only characters (just like Firefox ignores `\0`-words). Still a workaround, but better than the wrong behavior. On the other...
Created an issue in the project developing the Ukrainian dictionary. https://github.com/brown-uk/dict_uk/issues/306
@Predelnik: the workaround you implemented in https://github.com/Predelnik/DSpellCheck/pull/302/commits/c31e59bdbcd610c587e866acf2f023b7ff982d42 is not good. The typical error/typo in Ukrainian is the usage of Latin «i» instead of Ukrainian «і» (e.g. «гранiтний» instead of «гранітний»)....
Hmm, to be honest I don't see your ```because I only add logic to treat word with Latin characters as incorrect without changes for other cases``` neither in https://github.com/Predelnik/DSpellCheck/pull/302/commits/c31e59bdbcd610c587e866acf2f023b7ff982d42 nor...
I mean - `std::ranges::count(word_to_check, '0')` is the complete iteration over the original word - `std::ranges::count(buf, '0')` is the complete iteration over the converted word If you change the name of...
Ok it's up to you, I just provided my argumentative feedback after reviewing the code. My point is "less optimal code there", "less optimal code somewhere else" - at some...
@Predelnik It looks like the developer of the Ukrainian dictionary is willing to [remove](https://github.com/brown-uk/dict_uk/issues/306#issuecomment-1181708407) the iconv lines in one of the upcoming releases. So wait a bit with merging the...
Hmm, do all Ukrainians always write foreign language words (used untranslated in the Ukrainian language) properly, without errors/typos? Would not that be better to (let the corresponding language dictionary) spellcheck...
My main use case is [Notepad++](https://notepad-plus-plus.org/) with [DSpellCheck plugin](https://github.com/Predelnik/DSpellCheck/issues/270), i.e. a text editor without a special file format for text documents like .doc or .odt and thus no way to...