endym
endym
I use the official ownNotes app from play store.
Hi! All requested changes are done IMHO. Just to be sure: Is something still missing?
I've also addressed codebase standards (prefixed all class members/functions with "this->", made private class fields protected).
@jesserockz I've no idea, why this PR is marked as closed now. It wasn't me. The only thing I've done was to reset the branch in my forked repo to...
> But, this PR does not do that, it only ever sets the pin to high at the beginning of transfer, and low after transfer. (It also sets the load...
> Why are you holding the load pin low from setup exactly? Low means that the MAX6921 output latch will not be updated from shift register.
I've tried to implement the discussed changes (replace LOAD with CS pin), but it doesn't work. The CS methods `enable()` and `disable()` contains a lot of SPI-specific logic (incl. OS...
@jesserockz How should we proceed now?
@jesserockz Any chance that this PR will be merged?
> There are many PRs open to review and not so many reviewers. Pinging (and sending emails) will only get a PR ignored in the future. Imagine you create a...