DIVYANSHU RAJ comments

Results 63 comments of


                                            DIVYANSHU RAJ

Test added to p5.fft

@therewasaguy please have a look

FFT.setInput() doesn't disconnect old input

@therewasaguy i think if we intent to listen to all the sources then we should rename `setInput` to `addInput` ? or if we intent to just listen to the currently...

update p5 sound examples to start audio on a user gesture

> Change was made to the inline examples here [processing/p5.js-sound#403](https://github.com/processing/p5.js-sound/pull/403) [processing/p5.js#3988](https://github.com/processing/p5.js/pull/3988) > > and now the examples that live in the website repo also should be updated. The examples should...

Addition to SoundFile class

@nakul-shahdadpuri i encourage your thoughts , it would great if you present things in particular. like what parameters do you think should be merged and how will it increase the...

Envelope uses ES6 class

@Ajaya1000 also check the examples if the p5.envelope is runnig fine https://github.com/processing/p5.js-sound/blob/main/examples/envelope/sketch.js and let me know if everything is fine . I wil verify and then we can merge this...

loadSound pause() method working similarly to stop()

@satyasaibhushan these are some important and feature breaking issues and I believe new comers are more enthusiastic , however there are bunch of other GFE . You can have a...

Adding test for envelope class

@iRohitSingh you can use beforeEach() and afterEach() hook to initiate and dispoe the envelope instance

Adding test for envelope class

@therewasaguy i think we should merge this one before #608 it can be used to test that pr

added check for [bins] argument in fft method of P5, along with unit Test( in es6 style)

@therewasaguy please review this Pr!

added check for [bins] argument in fft method of P5, along with unit Test( in es6 style)

> Also, just a note: > > In the Web Audio API, the `AnalyserNode.frequencyBinCount` is `Read only` (I'm looking at the MDN documentation for reference https://developer.mozilla.org/en-US/docs/Web/API/AnalyserNode). It is always half...