p5.js-sound icon indicating copy to clipboard operation
p5.js-sound copied to clipboard
verified publisher icon processing

Envelope uses ES6 class

Open Ajaya1000 opened this issue 4 years ago • 2 comments

changed to es6 class structure

Ajaya1000 avatar Apr 25 '21 16:04 Ajaya1000

@Ajaya1000 also check the examples if the p5.envelope is runnig fine https://github.com/processing/p5.js-sound/blob/main/examples/envelope/sketch.js and let me know if everything is fine . I wil verify and then we can merge this one

endurance21 avatar Apr 26 '21 04:04 endurance21

@endurance21 I have made the suggested changes and all examples using envelope classes are working as expected.

Ajaya1000 avatar Apr 26 '21 07:04 Ajaya1000

Hi @Ajaya1000 can you please look into the merge conflicts, if you are busy I can resolve those conflicts and make a new PR fixing merge conflicts around the same :)

Abhijay007 avatar Dec 30 '22 17:12 Abhijay007

I'm going to close this for organizational purposes since the changes have been merged in as part of @Abhijay007's PR. Thanks for your changes @Ajaya1000!

davepagurek avatar Jan 06 '23 21:01 davepagurek