Ian Forbes

icon company @vmware icon location Austin, Texas

Results 11 comments of Ian Forbes

How to place `intercept_hook_point*` pointers on thread local storge and actually use it?

TLS is reset to zero after `clone`. You have to set the variables manually every time you create a new thread. The result is that `intercept_hook_point_clone_child` will never work and...

fix CMakeLists.txt bug

Why did you close this? It seems valid.

Update README.md

There are no changes to the README in theses commits.

Missing "NOT" in CMakeLists.txt

Are you trying to create an in-source build?

Missing "NOT" in CMakeLists.txt

Did you build in `.`?

segfault in mprotect

Can you share a backtrace if possible?

Compile-in clone3() crash fix even when the glibc version is < 2.34

The presence of `clone3` is determined by the kernel version, not the glibc version so the title is incorrect. Clone3 was added in kernel 5.3.

Linking error when new external variable is introduced in intercept_wrapper.S

You'll have to post the link command and symbol table for the objects involved in the link with `readelf -s`. There's not enough info here.

Linking error when new external variable is introduced in intercept_wrapper.S

Also for `movq intercept_hook_point (%rip), %rcx` the address of intercept_hook_point will be relative to `%fs`

intercept_hook_point_clone_child() is not called within the thread created by fork(), not pthread_create().

You can't return after calling `clone` in the child with a new stack at [intercept_routine:702](https://github.com/pmem/syscall_intercept/blob/master/src/intercept.c#L702) because there is nothing to return to. The return address is stored on the stack...