Ryan Thomas Lynch
Ryan Thomas Lynch
I still have this enable_if issue with VS Code 1.68.0 and C/C++ Extension Version 1.10.7 (from 6/16/2022). I am encountering this on the LLVM project with this constructor: https://github.com/llvm/llvm-project/blob/dc562d570dfe7589a27497c1210b105d9d8603f0/llvm/include/llvm/ADT/StringRef.h#L925 Same...
> Are you seeing this issue in the wild somehow, or is there a test we can add? Not sure how to reproduce this on command with firtool, but I...
I also added a `getBufferID()` method so that FIRParser could still easily make a new lexer for `parseModuleBody`. `importFIRFile` still assumes that the "main file ID" is the correct buffer...
Do I need to wait for a codeowner to merge or ping someone? Lattner is still listed as the only codeowner here: https://github.com/llvm/circt/blob/6c33d7cec3eb1e31ff07d0387d514c1fc9a10e30/codeowners/firrtl.json#L5 I'm not familiar with the procedure here,...
@seldridge requesting review
> I'm still not able to repro. Does [@cg2916](https://github.com/cg2916)'s work around work for everyone? If not, I'll re-open the issue. The issue ~~is~~ was occurring for me with extension version...