Ned Molter

Results 120 comments of Ned Molter

@mkelley thanks very much for the helpful comments! I had a few specific questions as well, if you don't mind. 1. the output of this code is three different groups...

@mkelley ok, I incorporated all of your comments - I put astropy units onto all the input and output quantities, including your suggestion to allow for an EarthLocation structure to...

Ok, I fixed everything you suggested @mkelley , thanks again for all your help! I think this is nearly complete now. I added some documentation and some more tests. What...

Ok, I added tests for the special cases for Saturn and Neptune. It looks like now the oldest dependencies checks are failing because QTable doesn't like the "units" keyword. But...

> > It sounded like there was some debate over how exactly to do the request handling. Would someone be willing to just make the edits they see fit? >...

I still didn't know what to do with https://github.com/astropy/astroquery/pull/2358#discussion_r880860547 so that might still need looking at

Is there a back-compatible way to rewrite `epoch.utc.to_value("iso", subfmt="date_hm"))`? This passes the tests with tox on my machine but fails here.

@bsipocz thanks for your continued help with this! I finally made some more progress - sorry for the delay. But now the "oldest dependencies" checks are failing due to an...

Thanks @bsipocz ! I went ahead and started building this. I submitted a draft pull request [here](https://github.com/astropy/astroquery/pull/2358). At this stage I have a minimum working example written that can make...

@eerovaher @mkelley @bsipocz Thanks again for your help with this piece of code! Is it still possible to get this merged for 5.2? if so, what is needed from me...