Emil Uzelac
Emil Uzelac
Hey guys, I searched high and low, contacted folks and still don't know why this error shows, or how to fix it. ``` Fatal error: Cannot instantiate interface PhpParser\Parser in...
Just an opinion that's all :) Cherry options are bit confusing to me, theme adds many different options and not sure if the all of them are useful. One of...
[../extras.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/functions/extras.php#L80-111) [../utilis.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/functions/utils.php#L62-80) --- `$_COOKIE` are not something themes should use, if really have to, please see http://codex.wordpress.org/WordPress_Cookies and use core instead. @justintadlock please confirm.
[../styles.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/functions/styles.php#L35) [../scripts.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/functions/scripts.php#L81) --- We will leave this one as question to @justintadlock since this part of codes are his ;) Why do we need `wp_register_style` and `wp_register_scripts`? I understand that...
[../class-cherry-page-builder.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/admin/class-cherry-page-builder.php#L73) --- For adding admin pages use `add_theme_page()` instead of `add_menu_page()`.
[../screenshot.png](https://github.com/CherryFramework/cherryframework4/blob/master/screenshot.png?raw=true) --- screenshot.png should be an actual design of your theme and with recommended larger format: 1200px x 900px for retina and HD screens
[../template-tags.php](https://github.com/CherryFramework/cherryframework4/blob/master/lib/functions/template-tags.php#L472-514) --- While this is a nice feature, it doesn't really belong in themes.
[various files...](https://github.com/CherryFramework/cherryframework4/search?utf8=%E2%9C%93&q=f+%28+%21defined%28+%27WPINC%27+%29+%29+%7B) --- I don't think that this part is needed, there are no true benefits from it: ``` // If this file is called directly, abort. if ( !defined(...
I would highly recommend [switching](https://github.com/CherryFramework/cherryframework4/tree/master/lib/admin/pages) from options framework to WordPress [Customizer](http://ottopress.com/tag/customizer/). Theme Review Team just [announced](https://make.wordpress.org/themes/2015/04/21/this-weeks-meeting-important-information-regarding-theme-options/) Customizer as a requirement if you are uploading to WPORG and you never know...
Screenshot should be a reasonable facsimile of your theme after it is initially activated. Logos and graphics are good, but it does not represent your theme correctly. You might want...