Emilio Mayorga

Results 35 issues of Emilio Mayorga

The documentation retains the [text about the use of Git LFS](https://doc-test-echopype.readthedocs.io/en/latest/contributing.html#test-files). But I think we've effectively stopped using LFS, right? If so, should I remove that text from the docs...

infrastructure

(Originally discussed in https://github.com/OSOceanAcoustics/echopype/issues/210#issuecomment-822642399) For EK60: - Populate `Sonar/sonar_software_name` attribute. Right now it's left blank; see [convert/set_groups_ek60.py#L170](https://github.com/OSOceanAcoustics/echopype/blob/dev/echopype/convert/set_groups_ek60.py#L170) - `Sonar/sonar_model` attribute entry is "ER60". It should be EK60. Currently EK60 `Sonar/sonar_model`...

conventions

The use case that drove the development and testing of `update_platform` was a single set of Saildrone data files from the Pacific Hake survey, with one EK80 raw file with...

bug
enhancement

Suggestions for improvements to the new `echopype.verbose()` functionality implemented in PR #772, pertaining to options available when passing a `logfile` argument. See discussions starting at https://github.com/OSOceanAcoustics/echopype/pull/772#issuecomment-1212355025

enhancement

There are currently no calibration tests for ES70, ES80 and EA640 data. See #759 for background and reference to an ES80 sample raw file. There's also a sample ES70 raw...

tests

I recently created a centralized module that stores attribute values (and related info) from SONAR-netCDF4 v1.0: [echodata/convention/attrs.py](https://github.com/OSOceanAcoustics/echopype/blob/dev/echopype/echodata/convention/attrs.py). We've decided that it should be in a yaml file rather than a...

conventions
design

Investigate what platform or sonar/beam metadata attribute exists or should be added that clearly specifies the "direction" the echosounder is oriented (eg, downward vs upward looking). This need came about...

enhancement
data format

The `test_data` directory has grown to be untidy. For example: - For ek80 files, there are 3 top-level directories - For sample converted files, we have a couple of file...

docs
tests

AZFP has several variables that are unprocessed (eg, sensor signals) or have no analog in SONAR-netCDF4 v1. In echopype v0.6.0 we're moving many of these variables from the `Beam_group1` group...

enhancement

Copying observations from https://github.com/OSOceanAcoustics/echopype/pull/655#issuecomment-1112438117, and my follow up, *unsuccessful* R&D. Re: https://echopype.readthedocs.io/en/stable/api.html > Can someone help me in adding the `create_echogram` function into the api reference dropdown list in the...

docs