Matheus Santana

Results 13 comments of Matheus Santana

Hi @spderosso @r-hoogenboom I'd like to tackle this one. Did you already start thinking about how it should work? If not, I can come up with a proposal.

Thank you for your suggestions, @r-hoogenboom. LGTM. I'd only add that we should strive easing the pain of removing git submodules -- which [appears as the top most relevant questions...

This is related to https://github.com/sdg-mit/gitless/issues/56

@spderosso what do you think about this ([demo](https://asciinema.org/a/150863))? There are probably some uncovered edge cases but I think this PR addresses the use case which seems to be the most...

@adriancole 1. what do you mean by a shimmer of some sort? 2. do you think this project would be a good option for zipkin-mongo instrumentation? https://github.com/abesto/zipkin-mongodb Thanks!

@chrisvfritz this change doesn't seem to break any more tests from the current suite (there was already one failing test). I'd gladly straighten things up (maybe even add some test...

This way neither one matches: ```ruby filter = LanguageFilter::Filter.new matchlist: ["c\\*"] filter.match?('This excerpt c* should match.') #=> false filter.match?('But this c should not.') #=> false ``` I've taken on another...

The problem seems to be the wrapper regex: when we use c\* it is translated into \bc\*\b which fails because an asterisk (like in "c*") is not considered a word...

Thanks, @chrisvfritz. You're completely right about the `\B` idea. I've been searching around for solutions and ended up with a simpler version of the [`CREATIVE_END_REGEX`](https://github.com/chrisvfritz/language_filter/commit/f6484006#diff-1e6b4ab0d8cdc987543942145bb72fa4R14) which would meet my purposed...

Relates to https://github.com/microservices-demo/microservices-demo/issues/755