Elliot Gorokhovsky
Elliot Gorokhovsky
It would be great if uiCA were supported as a tool in godbolt similar to llvm-mca. In https://github.com/compiler-explorer/compiler-explorer/issues/2843, [RubenRBS](https://github.com/RubenRBS) indicated that they would be willing to review a PR adding...
When `ZSTD_decompressStream()` is called with `outBuffer == {NULL, 0, 0}`, there is undefined behavior [here](https://github.com/facebook/zstd/blob/dev/lib/decompress/zstd_decompress.c#L2182) when 0 is added to the NULL outBuffer pointer. UBSAN reports this as "runtime error:...
Recently `windows-latest` started resolving to `windows-2022` (rather than 2019) on Github Actions, breaking our CI. I changed all `windows-latest` tests to `windows-2019` in https://github.com/facebook/zstd/pull/3061. It's not urgent, but sometime soon...
Many of our Travis CI tests run on special hardware (like power pc) and cannot be migrated to GitHub actions (except possibly via QEMU, which isn't exactly equivalent). However, we...
The fact that you can create multiple `compressobj` from a single `ZstdCompressor` allows for foot-guns such as: ``` a = zstandard.ZstdCompressor() b = a.compressobj() c = b.compress(b"prefix") d = a.compressobj()...
On 0.17.0, the following example doesn't throw an error: ``` >>> zstandard.decompress(zstandard.compress(b"foo") + b"garbage") b'foo' ``` Perhaps debatable, but I think an error should always be thrown if there is...
This is a code-complete draft PR for the external matchfinder API. It is ready for code review, but still needs some documentation work and build tweaks. Here is a list...
[This assert](https://github.com/embg/zstd/blob/dev/lib/compress/zstd_compress_internal.h#L785) which was added as part of short cache has uncovered two bugs: * The short cache PR only validates that hashLog is
We currently detect BMI2 instructions at runtime, but users can only benefit from AVX2 if they compile with `-march=haswell`. It would be nice to provide AVX2 support to users who...
There is a safety check in all zstd dictionary matchfinders which checks that the 4-byte repcode match candidate doesn't span across the dictionary and the prefix: ``` if (((U32) ((prefixStartIndex...