Ed Maste

Sigh, I didn't know/remember that #185 was open

This is one issue that prevented the FreeBSD clusteradm team switching to DMA internally: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208261

@corecode I want to see the FreeBSD commit mail generator (I think it was the problem) fixed to not generate lines > 998 chars, and I think I agree that...

I don't like just cutting it (silently losing information in an otherwise passed email). Given the choice of passing non-compliant lines and splitting I'd choose the latter. That leaves us...

For me I consider the line splitting to be a "best effort" to deliver malformated mail, and I'd be happy enough splitting at whatever point the we reach the line...

It's the outgoing mail side of this issue that affected the FreeBSD commit mail generator. It is true that the script should not generate long lines, but it's handled by...

@bapt added a patch to the FreeBSD base system for this, in https://github.com/freebsd/freebsd-src/commit/b0b2d05fd0609d504236e5429cef421a35237bd6 (and a bugfix from me in https://github.com/freebsd/freebsd-src/commit/1a0dde338df8b493d74dcb2f7bbaaa6c02cab371). This is slightly different from the proposal in https://github.com/corecode/dma/pull/49, in...

@corecode getline returns -1 on error or EOF, I think the feof/getline loop is non-canonical but I think checking getline's return for >0 is the appropriate condition. I think this...

@corecode ah, prior to bapt's change we had: ``` if (fgets(line, sizeof(line) - 1, stdin) == NULL) break; ``` so same amount of error checking. I think we can just...

I think it's fine to use getline()'s -1 return I have a FreeBSD review in https://reviews.freebsd.org/D34159