Michiel Hendriks

Results 16 comments of Michiel Hendriks

The number is wrong because the pugin assumes that an unstable build is a failed build. If you have 2 failed builds, 8 unstable builds; then the plugin reports 10...

The problem is that people can contribute to different projects, from different organizations. These projects/organizations have their own style guides and also own checkstyle configurations. They also often use specific...

The parenthesis is an error on my part, they should not be there. ``` {% assign foo = bar == quux %} ``` That is valid in liquidjs. [demo](https://liquidjs.com/playground.html#eyUgYXNzaWduIGJhciA9IDEgJX0KeyUgYXNzaWduIHF1dXggPSAyICV9CnslIGFzc2lnbiBmb28gPSBiYXIgPT0gcXV1eCAlfQoKZm9vID0gYmFyID09IHF1dXgKe3tmb299fSA9IHt7YmFyfX0gPT0ge3txdXV4fX0KCg==,e30=)

I've used a slightly different way to achieve the same result by using a custom `RouteDefinitionLocator` ```java @ConfigurationProperties("my-gateway") public class MyGatewayProperties { private Map routes = new LinkedHashMap(); public Map...

I would also be nice if there was an option to include the original file (untouched) in the resulting image set. So for example ``` Image("some-image.jps", { widths: [300], formats:...

This is the template we use: https://gist.github.com/elmuerte/54fc63ccc07ed82b28ac9c573b2b26e9 Besides generalizing some parts in the notification it offers a bunch of deeplinks where possible. It also contains a filter at the top...

> @elmuerte, if you have some time, would you mind trying this change with the test setup you had in #1752 ? Quite a few things changed in the past...

Reverted back to 5.3.2 and still couldn't reproduce it. So there must have been an assertion in our test suite resulting in the problem, and it is no longer there....

I just noticed that explicitly defining a value for the nil property on the commandline does not fix it. `mvn org.openrewrite.maven:rewrite-maven-plugin:6.25.0:dryRun -Dsha1=foo` Results in a similar error (but no automatic...

This dependency should never be downloaded as it's the root of the project. The dependency would probably never exist in a remote repository anyway as it would be the current...