ellisms
ellisms
Hi @PurpleAmyr - following up on this PR. The example-pattern.json file is invalid. Once corrected, I can move forward with reviewing.
@PurpleAmyr I tried testing this and the rule fails to invoke. Can you take a look?
Hi @PurpleAmyr - yes, I ran `aws events put-events --entries file://testEvent.json` The EB rule has an invocation failure, and the error sent to the DLQ is: ` ApiDestination returned HTTP...
I ran through this workshop today and can confirm the live site is still not updated even though the source code is updated.
I'll take a look at EC2.
@dominikhei I'd go with option 2. A quick scan of the current waiter code in the hook doesn't reveal anything special. A custom waiter would be able to handle it.
@jeromevdl Were you able to review my comments and make changes?
Sorry, I didn't approve them. They are now approved and this is in the queue to publish.
Hi @rafaelbernard . Thanks for the submission. Since this is a Lambda extension, I think it fits better in the [aws-lambda-extensions](https://github.com/aws-samples/aws-lambda-extensions/blob/ad2aceeb9f6e59ca1e6a5bf04197ca9009cb2458/CONTRIBUTING.md) repo. I recommend resubmitting it there.
Thanks @archiev4 . Can you resolve each of the conversations?