Elliot Fehr
Elliot Fehr
/remove-lifecycle stale
/remove-lifecycle rotten
/remove-lifecycle stale
@carlhoerberg @dentarg Curious if there are any thoughts for this feature addition?
I'm pretty new to crystal lang and shards and was wondering if you have any tips for making the `statsd` dependency optional?
> Sorry, I was thinking too much like a Ruby developer when I said we could make `statsd` an optional dependency :) Here we compile a binary so it makes...
@dentarg just rebased on master but am not seeing CI kicking off. Guessing this is due to GH actions being degraded at the moment: https://www.githubstatus.com/ Edit: Looks like they are...
I'm not too sure how to resolve these CI errors: https://github.com/cloudamqp/amqproxy/runs/5591692534?check_suite_focus=true On my fork it appears there are also linting errors unrelated to changes in this PR: https://github.com/elliotfehr/amqproxy/runs/5591765809?check_suite_focus=true
@dentarg CI passed in https://github.com/cloudamqp/amqproxy/pull/68/commits/3e7de7c362c3351f4e6d371f985804e65e72fb8d! Let me know if there are any other changes you'd like to see!
@carlhoerberg Curious if you have any thoughts on this?